Skip to content

Update MSRV to 1.83 #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

Update MSRV to 1.83 #7066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ exclude = [

[workspace.package]
version = "2.0.0"
rust-version = "1.82"
rust-version = "1.83"
authors = ["The ICU4X Project Developers"]
edition = "2021"
repository = "https://github.com/unicode-org/icu4x"
Expand Down
16 changes: 8 additions & 8 deletions Makefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ category = "ICU4X Development"
env = { ICU4X_DATA_DIR = "../stubdata" }
script_runner = "@duckscript"
script = '''
exec --fail-on-error rustup install 1.82 --profile minimal
exec --fail-on-error rustup install 1.83 --profile minimal
# Exclude internal tools (Make sure to skip_package = true in the Cargo.toml for these crates)
exec --fail-on-error cargo +1.82 check --all-targets --all-features --workspace --exclude diplomat-gen --exclude codegen --exclude bakeddata --exclude depcheck --exclude diplomat-coverage
exec --fail-on-error cargo +1.83 check --all-targets --all-features --workspace --exclude diplomat-gen --exclude codegen --exclude bakeddata --exclude depcheck --exclude diplomat-coverage
'''

[tasks.ci-job-msrv-utils]
Expand Down Expand Up @@ -175,8 +175,8 @@ category = "CI"
env = { ICU4X_DATA_DIR = "../stubdata" }
script_runner = "@duckscript"
script = '''
exec --fail-on-error rustup install 1.82 --profile minimal
exec --fail-on-error cargo +1.82 make check-all-features-chunked 1
exec --fail-on-error rustup install 1.83 --profile minimal
exec --fail-on-error cargo +1.83 make check-all-features-chunked 1
'''

[tasks.ci-job-msrv-features-2]
Expand All @@ -185,8 +185,8 @@ category = "CI"
env = { ICU4X_DATA_DIR = "../stubdata" }
script_runner = "@duckscript"
script = '''
exec --fail-on-error rustup install 1.82 --profile minimal
exec --fail-on-error cargo +1.82 make check-all-features-chunked 2
exec --fail-on-error rustup install 1.83 --profile minimal
exec --fail-on-error cargo +1.83 make check-all-features-chunked 2
'''

[tasks.ci-job-msrv-features-3]
Expand All @@ -195,8 +195,8 @@ category = "CI"
env = { ICU4X_DATA_DIR = "../stubdata" }
script_runner = "@duckscript"
script = '''
exec --fail-on-error rustup install 1.82 --profile minimal
exec --fail-on-error cargo +1.82 make check-all-features-chunked 3
exec --fail-on-error rustup install 1.83 --profile minimal
exec --fail-on-error cargo +1.83 make check-all-features-chunked 3
'''

[tasks.ci-job-msrv-features]
Expand Down
2 changes: 1 addition & 1 deletion clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# called LICENSE at the top level of the ICU4X source tree
# (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).

msrv = "1.82"
msrv = "1.83"
50 changes: 28 additions & 22 deletions examples/c-tiny/decimal/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions examples/c-tiny/decimal/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

[package]
name = "unused"
version = "0.0.0"
# To ensure it stays on older lockfiles. Update when our pinned nightly supports lockfile v4
rust-version = "1.81"
publish = false

[lib]
path = "unused"
Expand Down
50 changes: 28 additions & 22 deletions examples/c-tiny/segmenter/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions examples/c-tiny/segmenter/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

[package]
name = "unused"
version = "0.0.0"
# To ensure it stays on older lockfiles. Update when our pinned nightly supports lockfile v4
rust-version = "1.81"
publish = false


[lib]
Expand Down
Loading