Add test for shift left with overflow panic for Hijri #7102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
sffc
reviewed
Oct 15, 2025
|
It's not an error report from Firefox |
|
@robertbastian how do we know that? Firefox has been finding and filing a fair number of bugs on this crate around panics and such. Firefox uses icu_calendar. |
|
Ah, I see. I don't have a strong need to merge this, I generally like closing filed issues with regression tests. |
|
Moved it. |
Manishearth
force-pushed
the
month-range-regression
branch
from
b76e365 to
8aee658
Compare
Manishearth
force-pushed
the
month-range-regression
branch
from
8aee658 to
428f40f
Compare
|
This can be merged if people want, otherwise we should close this and the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7032. The issue itself was already fixed, this is just the regression test from the issue.