Define matching for simple integers, leave others up to implementations #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
reviewed
Nov 13, 2024
aphillips
added
registry
fast-track
|
(chair hat ON) We approved fixing this text in the 2024-11-11 call, so this is on the fast track. Group members should weigh in if they have comments. Note that I require two approvals to merge, per process. |
eemeli
commented
Nov 14, 2024
aphillips
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
I think this is now fine.
I note that the match instructions have this:
If the value of
keymatches the productionnumber-literal, then
The number-literal production handles fractions and exponents. The WG consensus is not to solve this just now, but really... it's goofy to allow (in fact, require checking for) keys like 123.456 and 1.23e7 but not define a match for (some of) them. 'Nuff said. This PR accomplishes the goal set out for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More explicitly defines numeric matching for when it's well-defined, and when it's not well-defined.
Leaves values beyond non-negative integers as implementation-defined, and replaces the JSON reference with the
digit-size-optionABNF rule, as it's a better fit.