OpenQASM3 Frontend#2842
Conversation
|
In this one I believe only Besides these, should be fine. Kindly have a look and let me know if there are any thoughts :) . |
natestemen
left a comment
There was a problem hiding this comment.
Awesome start! A few high level comments to align on before we get into the weeds.
- Reverted type ignores where possible.
|
@natestemen Greetings, Hope you're doing well. Anything I need to do for this PR? |
b-goldsmith
left a comment
There was a problem hiding this comment.
Doing a search to see where the other frontends are included in the code...
@ACE07-Sev while I see test cases added for openqasm in the existing test files, I do not see specific openqasm test cases. The other frontends in mitiq/interface/mitiq_* include a tests folder with specific use cases. We should be testing things for openqasm, like confirming expected behavior when an invalid string is provided.
mitiq/README.md includes a Supported frontends section that should be updated.

In docs/source/apidoc.md there is an Interface section that includes the other frontends.
As a reminder, we should create an issue to include an example of ZNE with OpenQASM3. Once that is completed the docs/source/guide/frontends-backends.md can be updated with a link like the other frontends.
|
Greetings Brian, Hope you're doing well. Thank you for the review!
I'd appreciate giving me a list of items to write testers for. I can't really use other interfaces as an example since they differ significantly from one another. The other items you mentioned seem to be the doc parts which I'll add now. |
|
@bdg221 OpenQASM doesn't have a logo apparently. What image should I use? |
natestemen
left a comment
There was a problem hiding this comment.
Looking good, but a few individual unit tests demonstrating basic circuit conversions would be useful, and we need to sort out the type of object we expect from users. I think str is the most user-friendly, but I'm not sure that would work in the current state.
Thanks for your continued work here!
- Added tester for above. - Removed #TODO tag from `_count_gate_arities_openqasm`.
natestemen
left a comment
There was a problem hiding this comment.
LGTM! Just some small questions/comments.
Description
Initial commit to tackle #1503
License
Before opening the PR, please ensure you have completed the following where appropriate.