Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes all the missing images except three. #182

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

mattbloomfield
Copy link

@mattbloomfield mattbloomfield commented Jun 19, 2020

  • I'm acknowledging that my submission is free of all known copyright in at least the United States. (In general, works of the federal government should satisfy this criteria.)

I pulled all the images from https://memberguide.gpo.gov/#top except Kelly Loeffler. I pulled hers from her website directly (it is explicitly called out on her site as the official image -- https://www.loeffler.senate.gov/about-kelly/official-portrait).

I have also fixed all of the missing yaml files. In cases where a yaml file was missing I replaced the image with the official image from GPO and then updated the yaml file accordingly.

@hugovk
Copy link
Member

hugovk commented Jun 19, 2020

Thanks for all this!

First off, please could you leave all the files in their original locations and not move them to a congress-images dir?

@mattbloomfield
Copy link
Author

Whoops. Yes. So sorry, was moving the repo around locally and didn't grab the dot-files. Does this look better?

@hugovk
Copy link
Member

hugovk commented Jun 20, 2020

Thanks!

Some of the images have been made smaller, for example:

congress/original/A000376.jpg
congress/original/A000378.jpg

image

Also these:

congress/original/B001308.jpg
congress/original/G000589.jpg
congress/original/H001081.jpg
congress/original/J000301.jpg
congress/original/L000590.jpg
congress/original/M001205.jpg

And others.

Please could we have this PR so it only adds missing images?

And we could consider replacing existing images in another PR, if it's necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants