perf: Avoid frequent save-excursion calls in the citre-completion-at-point function.#192
Closed
milanglacier wants to merge 1 commit intouniversal-ctags:masterfrom
Closed
perf: Avoid frequent save-excursion calls in the citre-completion-at-point function.#192milanglacier wants to merge 1 commit intouniversal-ctags:masterfrom
save-excursion calls in the citre-completion-at-point function.#192milanglacier wants to merge 1 commit intouniversal-ctags:masterfrom
Conversation
…nt` function. Calling `save-excursion` repeatedly during completion is computationally expensive. Furthermore, checking if the point is at an operator is unnecessary, as completion candidates typically do not include operators.
milanglacier
changed the title
save-excursion calls in the completion-at-point function.save-excursion calls in the citre-completion-at-point function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function call chain
citre-completion-at-point->citre-tags-get-completion-at-point->citre-tags-get-symbol-defaulteventually callscitre-bounds-of-sym-or-op-at-point.Calling
save-excursionincitre-bounds-of-sym-or-op-at-pointrepeatedly during completion is expensive.Furthermore, checking if the point is at an operator is unnecessary, as completion candidates typically do not include operators.