fix(compatibility): - Optimized enum value processing to match Prisma…#235
Closed
javan-b wants to merge 2 commits intounlight:masterfrom
javan-b:master
Closed
fix(compatibility): - Optimized enum value processing to match Prisma…#235javan-b wants to merge 2 commits intounlight:masterfrom javan-b:master
javan-b wants to merge 2 commits intounlight:masterfrom
javan-b:master
Conversation
…'s expected documentation structure. BREAKING CHANGE: This change ensures that enum values are processed in a way that aligns with Prisma's engine, maintaining consistency in documentation handling and filtering out unnecessary entries.- Added specific handling for `@deprecated` documentation, mapping it to - Updated the `registerEnum` function to properly filter out empty entries in the `valuesMap` based on enum value documentation.- Ensured that enum values without `description` or `deprecationReason` are excluded from the `valuesMap` when registering with `registerEnumType`.the `deprecationReason` field in line with Prisma Engine behavior.- Improved compatibility with Prisma's enum value documentation format by ensuring only relevant metadata is included in the GraphQL schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
This change ensures that enum values are processed in a way that aligns with Prisma's engine, maintaining consistency in documentation handling and filtering out unnecessary entries.- Added specific handling for
@deprecateddocumentation, mapping it to - Updated theregisterEnumfunction to properly filter out empty entries in thevaluesMapbased on enum value documentation.- Ensured that enum values withoutdescriptionordeprecationReasonare excluded from thevaluesMapwhen registering withregisterEnumType.thedeprecationReasonfield in line with Prisma Engine behavior.- Improved compatibility with Prisma's enum value documentation format by ensuring only relevant metadata is included in the GraphQL schema.