Add index to foreign key (parent_id) column for optimized record retrieval & deletion #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses performance issues related to both record deletion and retrieval in the sqlalchemy_mptt library. Adding an index to the foreign key(parent_id) column improves the efficiency of both operations, significantly reducing the time taken for deletion and retrieval.
Collaborator
|
@akhil018 could you help in attempting to write a corresponding test for this change? |
fayazkhan
reviewed
Jun 25, 2025
| ForeignKey( | ||
| "{}.{}".format(cls.__tablename__, pk.name), ondelete="CASCADE" | ||
| ), | ||
| index=True |
Collaborator
There was a problem hiding this comment.
Hi @akhil018, which dialect is this patch for? Wouldn't the ForeignKey implicitly add the index as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was identified in the foreign key(parent_id) column, where retrieval and deletion of records took an unexpectedly long time. To optimize the retrieval and deletion process, this fix introduces a new index on the relevant foreign key (parent_id) column.
This commit addresses performance issues related to both record deletion and retrieval in the sqlalchemy_mptt library. Adding an index to the foreign key(parent_id) column improves the efficiency of both operations, significantly reducing the time taken for deletion and retrieval.