test(e2e): remove legacy scaffolding after Ginkgo migration - #532
Conversation
✅ Deploy Preview for urunc canceled.
|
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Hello @IrvingMg thank you for the cleanup. One comment that we can discuss over.
I think it would be better to place all the new functions of tests/e2e/common.go (e.g. getTestImages) in a separate file and keep the common go file as a file that contains common functions for the various tools. Maybe, a better file to place them would be tests/e2e/utils.go or rename tests/e2e/setup_test.go.
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
193200c to
3b7b814
Compare
Done. Moved the image management functions and constants to |
PR: #532 Signed-off-by: Irving Mondragón <mirvingr@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
PR: #532 Signed-off-by: Irving Mondragón <mirvingr@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
2 participants
Description
This PR cleans up the remaining unused code from the migration.
Related issues
How was this tested?
make e2etestLLM usage
Claude Code (Opus 4.6)
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).