docs(design): document loop autoclear for block bind mounts - #872
Draft
Vi-shub wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Explain why urunc clears loop autoclear before unmounting eligible bind mounts, and that delete restores it. Remove the inline TODO. Signed-off-by: Vi-shub <smsharma3121@gmail.com>
Vi-shub
force-pushed
the
docs/loop-autoclear-storage
branch
from
July 31, 2026 19:34
12dcdd9 to
c58c94b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As diving more in the codebase I observe this TODO and critical part to be documented.
Documents the loop-device autoclear behavior used when urunc turns host bind mounts into guest block devices.
This addresses the TODO in
pkg/unikontainers/block.gothat asked for storage-handling documentation covering:Also adds a short link from the design overview and replaces the long inline TODO with a pointer to the new page.
Related issues
Fixes #873 and comment that contributors.yaml is now a clean 3-line add (LF).
How was this tested?
getBlockVolumes/restoreBlockVolumesinpkg/unikontainers/block.godocs/design/*.mdis already included inmkdocs.ymlnavLLM usage
Claude Code assisted with drafting the documentation; I reviewed it for accuracy against the code.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).@cmainas - please take a look when you have a moment. Thanks for your time 😄