-
Notifications
You must be signed in to change notification settings - Fork 77
👌 Improve schema severity handling #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
+ Coverage 86.87% 87.96% +1.08%
==========================================
Files 56 70 +14
Lines 6532 9638 +3106
==========================================
+ Hits 5675 8478 +2803
- Misses 857 1160 +303
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the description, that all looks fine, but unfortunately I don't have time to go through the code in detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but there is some minor typos and a clarification I had that would be helpful to handle prior to merging.
Various schema reporting improvements:
needs_schema_severitysuppress_warningstype, so they can specifically be suppressedsn_schema_infosn_schema_warningsn_schema_violationinfoandwarningis logged aslogger.warning()violationis logged aslogger.error()for a different colorsuppress_warningslog_lvlinformation reflect what Sphinx does.Possible values are
warningorerror.log_lvlandtypefor children.This information is only required on the root, the nested fields are duplicates.
Field:in schema console reports if not setFixes: #1553