fix(response-panel): allow full screen and audio for video previews - #110
Open
princek-bruno wants to merge 2 commits into
Open
fix(response-panel): allow full screen and audio for video previews#110princek-bruno wants to merge 2 commits into
princek-bruno wants to merge 2 commits into
Conversation
VS Code denies the webview fullscreen permission and ships an ffmpeg with no AAC decoder, so the dead control is replaced by expanding the player, and mp4 audio is decoded through a vendored fdk-aac wasm build.
princek-bruno
force-pushed
the
fix/video-preview-fullscreen-and-audio
branch
from
August 11, 2026 11:50
e2bb0b5 to
8ffa4f3
Compare
princek-bruno
force-pushed
the
fix/video-preview-fullscreen-and-audio
branch
from
August 13, 2026 13:45
fa94c84 to
f6ceb3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full screen and sound now work in the video response preview, and the player is shaped like the one in the desktop app.
Problem
Jira: VSCODE-63
Playing an mp4 response in the response pane, the picture plays but the full screen and unmute buttons stay greyed out, so the response cannot be viewed large or heard.
Root cause
Webviews run inside a frame that is not permitted to go full screen, so the browser refuses the request and disables its own button. And the editor ships a media build with no decoder for the audio format nearly every mp4 uses, so the player sees no audio track and disables the mute button.
Solution
Recordings / Screenshots
Before
After