Skip to content

fix(response-panel): allow full screen and audio for video previews - #110

Open
princek-bruno wants to merge 2 commits into
usebruno:mainfrom
princek-bruno:fix/video-preview-fullscreen-and-audio
Open

fix(response-panel): allow full screen and audio for video previews#110
princek-bruno wants to merge 2 commits into
usebruno:mainfrom
princek-bruno:fix/video-preview-fullscreen-and-audio

Conversation

@princek-bruno

@princek-bruno princek-bruno commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Full screen and sound now work in the video response preview, and the player is shaped like the one in the desktop app.

Problem

Jira: VSCODE-63

Playing an mp4 response in the response pane, the picture plays but the full screen and unmute buttons stay greyed out, so the response cannot be viewed large or heard.

Root cause

Webviews run inside a frame that is not permitted to go full screen, so the browser refuses the request and disables its own button. And the editor ships a media build with no decoder for the audio format nearly every mp4 uses, so the player sees no audio track and disables the mute button.

Solution

  • Full screen is replaced with an manually added expand toggle that fills the webview, Esc to exit, since the full screen API cannot be used.
  • The audio track is pulled out of the mp4, decoded in WebAssembly by a vendored decoder, and played from a separate audio element kept in step with the video's play, pause, seek and speed. The video stays muted while that audio is in charge, so doubled sound is impossible on a host that can decode natively.

Recordings / Screenshots

Before

image

After

Screenshot 2026-08-06 at 5 08 41 PM

@princek-bruno princek-bruno changed the title fix(response-pane): working full screen and audio for video previews fix(response-panel): working full screen and audio for video previews Jul 31, 2026
@princek-bruno princek-bruno changed the title fix(response-panel): working full screen and audio for video previews fix(response-panel): allow full screen and audio for video previews Aug 3, 2026
VS Code denies the webview fullscreen permission and ships an ffmpeg with no AAC decoder, so the dead control is replaced by expanding the player, and mp4 audio is decoded through a vendored fdk-aac wasm build.
@princek-bruno
princek-bruno force-pushed the fix/video-preview-fullscreen-and-audio branch from e2bb0b5 to 8ffa4f3 Compare August 11, 2026 11:50
@princek-bruno
princek-bruno force-pushed the fix/video-preview-fullscreen-and-audio branch from fa94c84 to f6ceb3a Compare August 13, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant