fix(path-param) - Edit path param value in popup#86
Open
rajashreehj-bruno wants to merge 3 commits into
Open
Conversation
rajashreehj-bruno
force-pushed
the
VSCODE-32-Path-param-pop-is-not-allowing-to-edit-the-value
branch
from
July 20, 2026 06:41
e85b71e to
f691f9c
Compare
princek-bruno
suggested changes
Jul 20, 2026
princek-bruno
left a comment
princek-bruno
left a comment
Contributor
There was a problem hiding this comment.
Added few small review comments, Please check
| await expect(async () => { | ||
| const value = await getPathParamTableValue(editor); | ||
| expect(value).toBe(paramValue); | ||
| }).toPass({ timeout: 5_000 }); |
There was a problem hiding this comment.
This asserts in the memory store. Add a persistence test as well.
Close request tab-> openRequest -> await openRequestPaneTab(reopened, 'Params'); -> then expect the paramValue to still be there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path parameter values could not be edited from the variable-info popover that appears when hovering a
:paramtoken in the URL editor — the popover rendered the value as read-only. This makes path params editable inline (consistent with other editable variable scopes) and persists the change back to the request.Root cause
Two gaps:
In brunoVarInfo.tsx,
'path'was included in theisReadOnlylist, so the popover rendered the read-only.var-value-displayinstead of an editable field.Even if made editable,
updateVariableInScopehad no'path'case, so an edit had nowhere to go.Changes
brunoVarInfo.tsx: removed
'path'from the read-only scope check so the popover shows the editable value field for path params (process.env,runtime,dynamic,oauth2, andundefinedremain read-only).collections/actions.tsx: added a
'path'case toupdateVariableInScopethat locates the path param in the request'sdraft/requestparams by name, dispatches the existingupdatePathParamreducer, and saves the request — so the edited value persists and propagates to the Params → Path table.Testing
Added e2e spec path-params.spec.ts: creates a request with a
:userIdpath param, edits the value via the URL hover popover, and asserts it propagates to the Params → Path table.Added
openRequestPaneTabhelper in actions.ts and centralized the path-param/popover selectors in locators.ts.Jira ticket: VSCODE-32