fix/3216 regression for proxy config from v2 to v3#8112
fix/3216 regression for proxy config from v2 to v3#8112abhishekp-bruno wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR integrates a proxy configuration transformation utility into the Electron collection initialization flow. It imports Proxy Config Transformation on Collection Import
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| }; | ||
| } | ||
|
|
||
| brunoConfig.proxy = transformProxyConfig(brunoConfig.proxy); |
There was a problem hiding this comment.
Please verify if we needed to add this anywhere else, also we need to have a playwright test case teh verifies that the proxy is successfully imported
…fix/regressionbrunoProxyConfig_v2_to_v3
JIRA link - https://usebruno.atlassian.net/browse/BRU-3216
Description
Proxy settings were not being imported properly from JSON export file created with v2 and imported into v3.
Currently yaml import method works but the bru method still fails to import a collection.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit
Release Notes