Skip to content

fix/3216 regression for proxy config from v2 to v3#8112

Open
abhishekp-bruno wants to merge 3 commits into
usebruno:mainfrom
abhishekp-bruno:fix/regressionbrunoProxyConfig_v2_to_v3
Open

fix/3216 regression for proxy config from v2 to v3#8112
abhishekp-bruno wants to merge 3 commits into
usebruno:mainfrom
abhishekp-bruno:fix/regressionbrunoProxyConfig_v2_to_v3

Conversation

@abhishekp-bruno
Copy link
Copy Markdown

@abhishekp-bruno abhishekp-bruno commented May 27, 2026

JIRA link - https://usebruno.atlassian.net/browse/BRU-3216

Description

Proxy settings were not being imported properly from JSON export file created with v2 and imported into v3.
Currently yaml import method works but the bru method still fails to import a collection.

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

Release Notes

  • Chores
    • Improved proxy configuration handling during collection import and initialization for better consistency in configuration processing.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3ce97dac-2db1-4b1c-9707-f5ef12e4bafb

📥 Commits

Reviewing files that changed from the base of the PR and between 6b7e5f3 and 92d73db.

📒 Files selected for processing (1)
  • packages/bruno-electron/src/ipc/collection.js

Walkthrough

The PR integrates a proxy configuration transformation utility into the Electron collection initialization flow. It imports transformProxyConfig from @usebruno/requests and applies it to the default brunoConfig.proxy during collection import, ensuring proxy settings are normalized before use.

Proxy Config Transformation on Collection Import

Layer / File(s) Summary
Proxy config transformation integration
packages/bruno-electron/src/ipc/collection.js
Imports transformProxyConfig and applies it to normalize brunoConfig.proxy when building the default config during collection initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • usebruno/bruno#6846: Applies the same transformProxyConfig helper in the CLI request runner for consistent proxy configuration normalization across environments.

Suggested labels

size/M

Suggested reviewers

  • lohit-bruno
  • naman-bruno
  • bijin-bruno
  • helloanoop

Poem

🔧 A proxy walks in, transformed and bright,
Configuration flows clean through the night,
Electron and CLI now sing in tune,
Normalization complete—not a moment too soon! 🎵

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a regression where proxy configuration wasn't being imported from v2 JSON exports into v3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

};
}

brunoConfig.proxy = transformProxyConfig(brunoConfig.proxy);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify if we needed to add this anywhere else, also we need to have a playwright test case teh verifies that the proxy is successfully imported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants