feat(tabs): add option to show open tabs across all collections#8727
feat(tabs): add option to show open tabs across all collections#8727celian-hamon wants to merge 3 commits into
Conversation
Adds a beta preference (toggled in Preferences > Display) that keeps open tabs from every collection visible in the tab bar together, instead of hiding them when switching the active collection. Closes usebruno#5070, closes usebruno#5807
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a beta preference for showing tabs across collections, updates tab rendering and close behavior with collection-aware handling, and expands related hotkeys to operate across all open tabs when enabled. ChangesTabs Across Collections
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant DisplayPreferences
participant ReduxPreferences
participant RequestTabs
participant Hotkeys
DisplayPreferences->>ReduxPreferences: save tabs-across-collections preference
RequestTabs->>ReduxPreferences: read beta preference
User->>RequestTabs: select or close tab
RequestTabs->>RequestTabs: build displayed tabs and resolve collection
Hotkeys->>RequestTabs: navigate, move, or close scoped tabs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/bruno-app/src/components/RequestTabs/index.js`:
- Around line 172-176: Update RequestTabMenu.handleCloseSavedTabs() to derive
saved-tab IDs from collectionRequestTabs rather than only collection.items,
resolving each displayed tab’s collection consistently with the other bulk-close
handlers so saved tabs from all displayed collections are included.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 818e140e-3f82-43df-8182-77b3ea2b0af1
📒 Files selected for processing (7)
packages/bruno-app/src/components/Preferences/Beta/index.jspackages/bruno-app/src/components/Preferences/Display/index.jspackages/bruno-app/src/components/RequestTabs/RequestTab/index.jspackages/bruno-app/src/components/RequestTabs/index.jspackages/bruno-app/src/providers/Hotkeys/index.jspackages/bruno-app/src/utils/beta-features.jspackages/bruno-electron/src/store/preferences.js
Derive Close Saved target ids from the displayed tab list, resolving each tab's own collection, so in tabs-across-collections mode it closes saved tabs from every shown collection instead of only the menu-owner's.
|
LGTM |
Adds a beta preference (toggled in Preferences > Display) that keeps open tabs from every collection visible in the tab bar together, instead of hiding them when switching the active collection.
Closes #5070, closes #5807
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit