Fix/multi environment import fails entirely if one file is invalid - #9051
Draft
Gopi-bruno wants to merge 12 commits into
Draft
Conversation
…r malformed or unsupported files
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rdize import modal buttons
…s and apply theme-aware accent colors in ImportEnvironmentModal
… environment imports without naming conflicts
…importing-environments' into fix/multi-environment-import-fails-entirely-if-one-file-is-invalid
…flicts exist and improve error handling for malformed files
…on and update accessibility attributes for selection buttons
…importing-environments' into fix/multi-environment-import-fails-entirely-if-one-file-is-invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BRU-3674
Description
This PR is built above the PR-9050 which introduces a modal when the user imports duplicate environments (with name conflicts) and provides the user with an option to import as copy/replace those envs. But if one of the env is malformed/invalid/corruped, we fail the import totally which is causing the user to reimport with specifically cherry-picking the valid env files again. This PR introduces a separate accordion to inform the user about the corrupted files and let the user import envs from the rest of the files whichout breaking the whole import process.
Problem
Failure to import the valid envs, if only one/few of them is invalid.
Fix
We'll inform the user about the invalid env files and still give the user an option to import envs from valid files.
Screenshots
Before
Screen.Recording.2026-08-24.at.6.06.38.PM.mov
After
Screen.Recording.2026-08-24.at.6.07.36.PM.mov
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.