fix(scripts): keep {{variables}} intact in req.getHost()

packages/bruno-js/src/bruno-request.js

@@ -1,5 +1,16 @@
 const HeaderList = require('./header-list');
 
+// The authority of a raw, uninterpolated URL: the scheme (if any), userinfo,
+// path, query and fragment removed, and the case left alone.
+const getRawHost = (rawUrl) => {
+  if (typeof rawUrl !== 'string') {
+    return '';
+  }
+  const withoutScheme = rawUrl.trim().replace(/^[a-z][a-z0-9+.-]*:\/\//i, '');
+  const authority = withoutScheme.split(/[/?#]/, 1)[0];
+  return authority.slice(authority.lastIndexOf('@') + 1);
+};
+
 class BrunoRequest {
   /**
    * The following properties are available as shorthand:
@@ -47,6 +58,17 @@ class BrunoRequest {
   }
 
   getHost() {
+    // Pre-request scripts see the URL before variables are interpolated, and
+    // `new URL()` mangles a `{{var}}` in the authority: `{{baseUrl}}/users` has
+    // no scheme so it throws, and `https://{{HOST}}/users` parses with the host
+    // lowercased to `{{host}}`, which then no longer interpolates. Read such a
+    // host straight from the raw string so it round-trips through
+    // `bru.interpolate()`.
+    const rawHost = getRawHost(this.req.url);
+    if (rawHost.includes('{{')) {
+      return rawHost;
+    }
+
     try {
       const url = new URL(this.req.url);
       return url.host;

packages/bruno-js/tests/bruno-request-get-host.spec.js

@@ -0,0 +1,50 @@
+const { describe, it, expect } = require('@jest/globals');
+const BrunoRequest = require('../src/bruno-request');
+
+const getHost = (url) => new BrunoRequest({ url, method: 'GET', headers: {} }).getHost();
+
+describe('BrunoRequest - getHost()', () => {
+  describe('interpolated urls', () => {
+    it('returns the host and port', () => {
+      expect(getHost('http://localhost:5000/api')).toBe('localhost:5000');
+    });
+
+    it('lowercases a literal hostname, as URL does', () => {
+      expect(getHost('https://API.Example.com/users')).toBe('api.example.com');
+    });
+
+    it('returns an empty string for a url it cannot parse', () => {
+      expect(getHost('not a url')).toBe('');
+    });
+  });
+
+  describe('urls still holding {{variables}}', () => {
+    it('keeps the case of a variable in the hostname', () => {
+      // #9234: `new URL()` lowercased this to `{{host}}`, which no longer interpolates
+      expect(getHost('https://{{HOST}}/test')).toBe('{{HOST}}');
+    });
+
+    it('returns the variable when it carries the scheme as well', () => {
+      // #9233: `{{HOST}}/test` has no scheme, so `new URL()` threw and this was ''
+      expect(getHost('{{HOST}}/test')).toBe('{{HOST}}');
+    });
+
+    it('keeps a port, literal or variable', () => {
+      expect(getHost('http://{{host}}:{{port}}/x')).toBe('{{host}}:{{port}}');
+      expect(getHost('http://{{Host}}:8080/x')).toBe('{{Host}}:8080');
+    });
+
+    it('stops at a query string or fragment', () => {
+      expect(getHost('{{baseUrl}}?page=1')).toBe('{{baseUrl}}');
+      expect(getHost('https://{{HOST}}#section')).toBe('{{HOST}}');
+    });
+
+    it('drops userinfo', () => {
+      expect(getHost('https://{{user}}:{{pass}}@{{HOST}}/x')).toBe('{{HOST}}');
+    });
+
+    it('leaves a literal host alone when only the path has variables', () => {
+      expect(getHost('https://API.Example.com/users/{{id}}')).toBe('api.example.com');
+    });
+  });
+});