fix redis: use FromString for double reply values - #1297
Closed
netliomax25-code wants to merge 1 commit into
Closed
Conversation
Member
|
LGTM |
|
Many thanks for the PR! @apolukhin is now importing your pull request into our internal upstream repository. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Jul 28, 2026
1. `Parse(..., To<double>)` converts floating-point reply values (`ZSCORE`, `HINCRBYFLOAT`, `ZADD ... INCR`) with `std::stod`, which respects the process `LC_NUMERIC` and keeps only the valid numeric prefix of the string. 2. under a comma-decimal locale `"3.14"` parses as `3.0`, and a reply like `"3.14x"` parses as `3.14` with the trailing bytes silently dropped, so a compromised or MITM'd server can return a corrupted value. Switched to `utils::FromString<double>`, matching the geo parser at line 58 and the score parser at line 166 in this file: it is locale-independent and rejects trailing junk, while numbers, scientific notation, and `inf`/`-inf` still parse the same. Added a regression test for the trailing-junk case along with valid and infinite values. --- Pull Request resolved: #1297 Co-authored-by: antoshkka <antoshkka@userver.tech> commit_hash:e5b7997828ad3c0a5d02d03bf9a62d907405f3bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse(..., To<double>)converts floating-point reply values (ZSCORE,HINCRBYFLOAT,ZADD ... INCR) withstd::stod, which respects the processLC_NUMERICand keeps only the valid numeric prefix of the string."3.14"parses as3.0, and a reply like"3.14x"parses as3.14with the trailing bytes silently dropped, so a compromised or MITM'd server can return a corrupted value.Switched to
utils::FromString<double>, matching the geo parser at line 58 and the score parser at line 166 in this file: it is locale-independent and rejects trailing junk, while numbers, scientific notation, andinf/-infstill parse the same. Added a regression test for the trailing-junk case along with valid and infinite values.