Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-components: Create
usa-identifier
web component #21base: develop
Are you sure you want to change the base?
Web-components: Create
usa-identifier
web component #21Changes from 1 commit
44495b4
299b123
973de11
e25ca97
ec9bd87
26b0497
dfdc3c9
0603ca8
b2264c8
5fd129e
21c5c23
0ae101e
5187659
3e35676
701aea8
5870445
36aebe9
11146d5
2300129
972e137
3295148
20f6be0
a29a5fc
311c8b4
aea6026
a4be4bc
ff13947
00cc022
1cb07c6
8a3afcb
87287be
95e034c
926b3ae
c61b751
cfe4d5a
dec6453
bcc13b1
ccfc05f
4a731f9
83c1d62
026ea11
8c4b5df
d820043
676561d
6a94ffc
f20b3b8
bc8e74a
622c0f9
7e1f4a7
a4c3508
a72ef76
7c43d59
2096376
89d281e
1d023af
c7a2ade
79f63e5
61a01d9
f64f2ee
0c5dc99
37ba970
089fe47
5876e4b
8c67e36
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing slot here, I'd expect to see
<slot>
elements in the component template.Example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lit recommends using component props as input. Source →
We should leverage reactive props if we're able to for defaults / configurable settings.