USWDS-Sandbox - UX Prototype: 2025 Q1 #176
Conversation
Use a more specific name to avoid confusion from multiple forms
mejiaj
changed the title
| <svg | ||
| class="usa-icon usa-tooltip" | ||
| data-position="top" | ||
| title="Accommodations are available but limited" | ||
| role="img"> | ||
| <use href="{{ '/assets/img/sprite.svg#info' | url }}"></use> | ||
| </svg> |
There was a problem hiding this comment.
One more thing about tooltip on mobile: I was expecting to be able to tap on the "i" icon and see the tooltip pop up. Curious if others feel that that should be the expected behavior (@amycole501 @alex-hull @mejiaj ). If so, I am still not able to tap on the icon and see the tooltip.
@jaclinec the tooltip is inside the label, but I was able to toggle it on Firefox for Android.
There was a problem hiding this comment.
@mejiaj I'm not able to toggle it on iPhone using Safari or Chrome. I wonder if it's a browser limitation or if we have any control over it? When I tap the "i" icon it briefly shows the tooltip for a split second and then takes me into the character count input.
There was a problem hiding this comment.
I spoke with James internally about the tooltip on mobile issue and it seems it might be an iPhone issue that'd require a lot of customizations and workarounds to "fix," so we are moving forward with testing it as-is. If this is a bug or enhancement to tooltip we need to make down the road, we can address it then. Right now it seems out of scope.
|
@jaclinec I've added the default values to the error state. Ready for final review. |
mejiaj
requested review from
alex-hull,
amycole501 and
jaclinec
and removed request for
mlloydbixal
There was a problem hiding this comment.
Just reviewed again and had just a couple more comments. One was about breadcrumb on mobile (should probably use default after all for "Book a tour" proto instead of modified, and keep the modified version for "Error" proto) and one more comment on tooltip for iPhone. This is 99% there!
- Remove zebra naming convention - Organize tests under time-based list
|
@alex-hull @jaclinec ready for final review, please let me know if I haven't addressed the outstanding issues. |
|
@amycole501 this is ready for FFR. |
There was a problem hiding this comment.
One small but notable change needed.
The third tab stop on the page goes to what appears to be an empty element. In NVDA I hear "Banner landmark, US National parks link"
The question I have is, is that the BANNER or the HEADER? Should it change to read something other than banner?
Here's what ANDI is showing
Can we fix it so that isn't a tab stop? I don't know that it's needed.
Logo markup matches recommended USA Header style. This fixes an A11Y issue where the tab stop was appearing blank and not highlighting on focus. More info in PR comment: #176 (review)
|
@amycole501 the third tab stop is the header from the last test. Specifically, the logo text "U.S. National Parks." Fixed the markup and it now should highlight correctly [13da400]. After |
Closes #168.
This PR creates the prototype for testing. It includes experimental component changes made in this branch and in uswds/uswds#ux-prototype-2025Q1.
Preview
Included experimental features
Created a feature branch on USWDS [
ux-prototype-2025Q1] which includes the following experimental features:Bugs found