Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Bug: [Fix heading on Community page] #2467

Closed
2 tasks done
sarah-sch opened this issue Jan 29, 2024 · 5 comments · Fixed by #2492
Closed
2 tasks done

USWDS-Site - Bug: [Fix heading on Community page] #2467

sarah-sch opened this issue Jan 29, 2024 · 5 comments · Fixed by #2492
Assignees
Labels
Affects: Content Relates to content Type: Bug A problem in the code

Comments

@sarah-sch
Copy link
Contributor

sarah-sch commented Jan 29, 2024

Describe the bug

Dan's name is a heading under "Community Managers" on this page. It shows up as part of the in-page navigation. Let's reformat so that his name is no longer in the heading structure.

Steps to reproduce the bug

  1. Go to https://designsystem.digital.gov/about/community/
  2. Look at the in-page navigation

Closed by

#2492

Screenshots

No response

System setup

No response

Additional context

No response

Code of Conduct

@sarah-sch sarah-sch added the Type: Bug A problem in the code label Jan 29, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Jan 29, 2024
@sarah-sch sarah-sch self-assigned this Jan 29, 2024
@sarah-sch sarah-sch added the Affects: Content Relates to content label Jan 29, 2024
@finekatie
Copy link
Contributor

Hey @sarah-sch , I'm looking at the page and there's a link on Dan's name to this page. Do we want to leave that link?

@finekatie finekatie moved this to On deck in USWDS Core Project Data Feb 1, 2024
@finekatie
Copy link
Contributor

Sarah and I talked about this today.
We should remove header tags at the very least. That should stop it from showing up in the On this page menu.

Things we need to discuss:

  • Is Dan the community manager? Should we have that there?
  • Is there a threshold for On this page functionality showing up on a short page?

@finekatie
Copy link
Contributor

finekatie commented Feb 6, 2024

@finekatie finekatie moved this from On deck to In progress in USWDS Core Project Data Feb 6, 2024
@brunerae brunerae removed the Status: Triage We're triaging this issue and grooming if necessary label Feb 9, 2024
@finekatie
Copy link
Contributor

finekatie commented Feb 12, 2024

Sarah approved this morning. Still needs to be merged. Waiting for dev.

@sarah-sch
Copy link
Contributor Author

Reviewed PR and attempted to merge changes this morning. Merged changes not appearing on site yet; will check later this morning and close or follow up with dev team if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Content Relates to content Type: Bug A problem in the code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants