Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Community: remove extra header tags #2492

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

sarah-sch
Copy link
Contributor

@sarah-sch sarah-sch commented Feb 15, 2024

Summary

Remove headings from around Daniel William's name.

Related issue

Closes #2467

Preview link

Preview link:
Community page

Problem statement

Describe the bug
Dan's name is a heading under "Community Managers" on this page. It shows up as part of the in-page navigation. Let's reformat so that his name is no longer in the heading structure.

Steps to reproduce the bug
Go to https://designsystem.digital.gov/about/community/
Look at the in-page navigation
Expected Behavior
No response

Screenshots
No response

System setup
No response

Additional context
No response

finekatie and others added 2 commits February 6, 2024 11:32
Remove h3 tags from Dan's name under "Community Managers". It's not an appropriate tag and also causes his name to show up in the "On this page" navigation.
@sarah-sch sarah-sch self-assigned this Feb 15, 2024
@sarah-sch sarah-sch requested a review from finekatie February 15, 2024 20:39
@sarah-sch sarah-sch changed the title Kf community header fix USWDS-Site - Community: remove extra header tags Feb 15, 2024
@sarah-sch sarah-sch marked this pull request as ready for review February 15, 2024 21:19
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved

@finekatie finekatie requested a review from thisisdano February 15, 2024 21:24
@finekatie
Copy link
Contributor

This continues to fail checks and we need fed final review to override.

@annepetersen annepetersen self-requested a review February 15, 2024 21:48
@annepetersen annepetersen merged commit ee59465 into main Feb 15, 2024
8 of 11 checks passed
@annepetersen annepetersen deleted the kf-community-header-fix branch February 15, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Bug: [Fix heading on Community page]
3 participants