-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alt tags and Showcase header on home.md #2478
Conversation
Discussed with content and a11y team. ANDI is flagging that the alt text in each of these images is redundant. Using "image remover" browser extention to Chrome one can see the page without the images and tell that those screen shots aren't critical for figuring out the purpose of those links We propose removing alt text, as the images are decorative. The links to the sites are what's important. We also propose changing the title on that section from "Showcase" to "Sites built with USWDS". It's clearer than Showcase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I've added @alex-hull and @amycole501 as reviewers just so that they can confirm the direction here. I also added a comment for them regarding the aria-label on the wrapping section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did discuss these changes and the H2 will be much clearer so the region ARIA could easily be removed to reduce redundancy. Most AT users will be navigating using heading levels most likely anyway.
The screen shot image descriptions aren't adding much in the way of context so reducing the wordiness of the page should improve usability for screen reader users. The links to the example sites are what's important for context.
No longer needed now that the h2 is more descriptive
…mepage-showcase-tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the accessibility team thinks this is better, then I approve.
Getting the following issue in Circle:
|
Pa11y error
It looks like this is happening because this This |
This PR also had some broken links that were causing errors.
cc @annepetersen I think this should be our SOP for broken reference links we find in the future |
Merging over false positives |
We propose removing alt text from website screenshots, as the images are decorative. The links to the sites are what's important. This was discussed with content and a11y team.
We also propose changing the title on that section from "Showcase" to "Sites built with USWDS". It's clearer than Showcase.
Summary
Removing alt tags from website screenshots and changing header on home page to make clearer.
Related issue
Closes #2469
Preview link
Preview link: https://federalist-ead78f8d-8948-417c-a957-c21ec5617a57.sites.pages.cloud.gov/preview/uswds/uswds-site/kf-homepage-showcase-tags/