Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add September and October Monthly Call to MCs page #2934

Merged
merged 12 commits into from
Nov 4, 2024

Conversation

finekatie
Copy link
Contributor

@finekatie finekatie commented Nov 1, 2024

Summary

Adding September and October Monthly Call content to Monthly Calls page

Important

The changelog date will need to be updated before merge.

Related issue

Closes #2849 and #2916

Preview link

[Monthly calls page]

Problem statement

Needed to get Monthly Calls page up to date with September and October call info.

Solution

September Monthly Call summary was approved and is ready to be added to the page. Video will not be going up until later in the month. Will need a new ticket or branch off this when it's ready.

Testing and review

Need someone to look and make sure links work and content is clean and clear.

trying to correct spacing in description
Adding video link and again trying to get spacing right.
Trying to correct spacing around lines 5&6. There are two paragraphs in this description, unlike the other call summaries.
@finekatie finekatie changed the title Add September Monthly Call to MCs page Add September and October Monthly Call to MCs page Nov 1, 2024
Found issue with date and colon in title field while collaborating with Charlie. Fixed.
adding space for two paragraphs
Don't have Q&A or video link yet, but getting this content added.
Added Oct event link and corrected slides link
Added changelog. Will need new date for publish.
@finekatie
Copy link
Contributor Author

Hi @annepetersen and @mahoneycm , I requested your reviews on the Monthly Calls page. September is fully added. We don't have Q&A or video yet for October, but I thought it'd be good to get this content up asap and then we can add those links as they are ready. Q&A needs some internal and FFR still. Thank you!!

making capitalization consistent
updating changelog to intended publish date
Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes: approved

Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Passing back to @annepetersen for merge 👍

@mahoneycm
Copy link
Contributor

Note: The SNYK error that is causing the circle/ci test_build failure will be resolved by #2867. We may want to merge that work first CC: @annepetersen

@annepetersen annepetersen merged commit 7c044e6 into main Nov 4, 2024
9 of 11 checks passed
@annepetersen annepetersen deleted the kf-septMC-MCspage branch November 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add September Monthly Call to Monthly Calls page
3 participants