Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Add changelog for in-page nav once update [#5878] #3062

Open
wants to merge 6 commits into
base: release-3.12.0
Choose a base branch
from

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Jan 13, 2025

Summary

Add a changelog for PR uswds/uswds#6172

Note

This could be considered a behind-the-scenes change since it shouldn't affect functionality. I was torn on if it should get a changelog, but I leaned towards tracking it since it does affect component JS. Let me know if you feel like a changelog is inappropriate here.

Important

We need to update the changelog dates before merge.

Preview link

In-page navigation changelog

@amyleadem amyleadem changed the base branch from main to release-3.12.0 January 13, 2025 23:09
@amyleadem amyleadem requested a review from mahoneycm January 13, 2025 23:22
@amyleadem amyleadem marked this pull request as ready for review January 13, 2025 23:23
@amyleadem amyleadem requested a review from a team as a code owner January 13, 2025 23:23
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this doesn't feel like a change that warrants a changelog. I'd rather keep the changelog lean to things that affect usability or implementation.

That said, this changelog looks good and I'll approve if we want to move forward with this!

@mahoneycm mahoneycm force-pushed the release-3.12.0 branch 2 times, most recently from 811eae7 to c87dd59 Compare January 23, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants