Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-Components - Alpha 1: Text input #76

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Oct 2, 2024

Summary

Created an alpha 1 web component for text input.

Related issue

Closes #17

Preview link

Text input story

Tasks

  • Initialize the default variant of the component in Storybook
    • Default variant has its own story in Storybook
    • Default elements are documented in JSDocs and appear in the component’s Storybook docs
    • Current component theme settings are translated into CSS variables
  • Match the component to USWDS 3
    • Visuals in default state match USWDS 3
    • Interaction in default state matches USWDS 3
    • Passes current manual accessibility tests from checklist
  • Create unit tests to confirm the component initializes in the shadow DOM

Testing and review

  • Confirm the component display matches the component in USWDS 3
  • Confirm the component passes manual accessibility tests
  • Confirm unit tests pass
  • Confirm all alpha 1 tasks have been completed

Comment on lines -61 to -64
color-scheme: light dark;
color: rgba(255, 255, 255, 0.87);
background-color: #242424;

Copy link
Contributor Author

@amyleadem amyleadem Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

I removed this because the component wasn't visible in the preview with this color scheme. It might need to be restored based on project needs, it just wasn't clear to me why we have this.

@amyleadem
Copy link
Contributor Author

@mahoneycm I unfortunately wasn't able to package this up like I'd like because I lost a bit of time doing the release on Friday. I believe this just needs a unit test and confirmation that it passes manual accessibility tests. I talked about this approach with @heymatthenry and @mejiaj, so they should be familiar with it and should be able to help answer any questions. I also added some links in the PR description to out previous conversation about it.

@amyleadem amyleadem changed the title Web-Components: Text component alpha Web-Components - Alpha: Text input web component Oct 7, 2024
@amyleadem amyleadem changed the title Web-Components - Alpha: Text input web component Web-Components - Alpha 1: Text input web component Oct 24, 2024
@amyleadem amyleadem changed the title Web-Components - Alpha 1: Text input web component Web-Components - Alpha 1: Text input Oct 24, 2024

export default css`
:host {
--theme-input-line-height: 1.3;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

The line height variable is currently hard-coded because I do not yet see how we will be handling normalization with our CSS vars.

@amyleadem amyleadem marked this pull request as ready for review October 25, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Component Text Input: Develop Alpha 1
1 participant