-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-Components - Alpha 1: Text input #76
base: develop
Are you sure you want to change the base?
Conversation
color-scheme: light dark; | ||
color: rgba(255, 255, 255, 0.87); | ||
background-color: #242424; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
I removed this because the component wasn't visible in the preview with this color scheme. It might need to be restored based on project needs, it just wasn't clear to me why we have this.
@mahoneycm I unfortunately wasn't able to package this up like I'd like because I lost a bit of time doing the release on Friday. I believe this just needs a unit test and confirmation that it passes manual accessibility tests. I talked about this approach with @heymatthenry and @mejiaj, so they should be familiar with it and should be able to help answer any questions. I also added some links in the PR description to out previous conversation about it. |
|
||
export default css` | ||
:host { | ||
--theme-input-line-height: 1.3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
The line height variable is currently hard-coded because I do not yet see how we will be handling normalization with our CSS vars.
Summary
Created an alpha 1 web component for text input.
Related issue
Closes #17
Preview link
Text input story
Tasks
Testing and review