Skip to content

Implement Tag Store Validations Through Existing TagUpdateRequest #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wunc merged 15 commits into from
Nov 14, 2025
Merged

Implement Tag Store Validations Through Existing TagUpdateRequest #167

wunc merged 15 commits into from
Nov 14, 2025

Conversation

@betsyecastro
Copy link
Contributor

@betsyecastro betsyecastro commented Oct 15, 2024 •
edited
Loading

Issue #48

@betsyecastro betsyecastro requested a review from wunc October 15, 2024 14:38
@betsyecastro betsyecastro self-assigned this Oct 15, 2024
@betsyecastro
Copy link
Contributor Author

betsyecastro commented Oct 18, 2024

The last commit includes:

  • The TagNameUniqueness rule to validate the uniqueness of both, a tag name being updated and the name of one or multiple new tags being added.
  • Validates the tag type for a single tag or multiple new tags.

@betsyecastro betsyecastro marked this pull request as draft October 25, 2024 16:12
@betsyecastro betsyecastro changed the title Implement tag store validations through existing TagUpdateRequest Implement Tag Store Validations Through Existing TagUpdateRequest Nov 21, 2024
@betsyecastro betsyecastro added the ✨ enhancement New feature or request label Nov 21, 2024
@betsyecastro betsyecastro marked this pull request as ready for review November 21, 2024 22:26
betsyecastro and others added 3 commits March 5, 2025 15:16
@betsyecastro
Fixes psalm errors
48412c2
@wunc
Tag request: use type declarations; formatting
d008589
@wunc
Tag validation: simplify
8517cf7 
Simplifying this by just preparing the request and converting to array before validating, instead of implementing our own multi-unique rule.
@wunc wunc merged commit 74365c7 into develop Nov 14, 2025
1 of 2 checks passed
@wunc wunc deleted the tag-store-request branch November 14, 2025 23:37
@wunc wunc mentioned this pull request Nov 14, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wunc wunc wunc approved these changes

Assignees

@betsyecastro betsyecastro

Labels

✨ enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@betsyecastro @wunc