-
Notifications
You must be signed in to change notification settings - Fork 0
Add ProfileSearchRequest #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shukla-m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@betsyecastro I reviewed the code and tested it locally and the string validation works as expected. Additional validations can be added as needed, but this update works for validating that the search input value is a string.
cc: @wunc
|
@wunc I used the What are your thoughts on this? If you’re available Friday or Monday, perhaps we could review it together with Shukla. Thank you. |
- adds max length of 100 - regex: use unicode character properties - formatting
Implements
ValidSearchStringvalidation rule onProfileSearchRequestto fix Sentry issue 6S - Array to string conversion and to improve the input validation on the search field.Github issue #48