-
Notifications
You must be signed in to change notification settings - Fork 0
Improve API Request Validations #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@betsyecastro I added myself as a reviewer on this PR, as we discussed last week, and pulled in the code to test locally. I tried the following URL which passes validation for the
This might not be an issue but wanted to mention, in case |
shukla-m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I tested the updates locally and it seemed to work as expected. See comment regarding person query parameter with invalid value, in case it causes any issues.
…built in validation rules for search fields
Implements the following API request validation rules: