Skip to content

Fix Trix JS Errors When Disabling File Uploads and Clearing Rows #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
betsyecastro wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix Trix JS Errors When Disabling File Uploads and Clearing Rows #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d4e4d9
Declare parent_elem variable with const to fix ReferenceError in clea…
betsyecastro Nov 26, 2025
62de680
Check element existence before attempting to remove
betsyecastro Nov 26, 2025
fb12668
Use chaining operator to check element existence before removal and c…
betsyecastro Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions public/js/app.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions public/mix-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"/js/app.js": "/js/app.js?id=bb647bfe8f8b8ae096323cb6ea42da03",
"/js/app.js.map": "/js/app.js.map?id=9f321a4814e4648916c37b2e980f55e7",
"/js/app.js": "/js/app.js?id=c447fe9c89c804aa1147b0351d0009a2",
"/js/app.js.map": "/js/app.js.map?id=55201ca1444675c47714f464498b2dd5",
"/js/manifest.js": "/js/manifest.js?id=dc9ead3d7857b522d7de22d75063453c",
"/js/manifest.js.map": "/js/manifest.js.map?id=389e00e7d7680b68d4e1d128ce27ff48",
"/css/app.css": "/css/app.css?id=bc1752c1cc35e38e55b5e618b7b4f544",
Expand Down
6 changes: 3 additions & 3 deletions resources/assets/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ var profiles = (function ($, undefined) {
* @param {HTMLElement} elem
*/
var clear_row = function (elem) {
parent_elem = $(elem).parent().parent();
const parent_elem = $(elem).parent().parent();
parent_elem.slideUp().find("input[type=text], input[type=url], input[type=month], input.clearable, textarea, select").val('');

const list_container = parent_elem[0].parentElement;
Expand Down Expand Up @@ -648,8 +648,8 @@ $(function() {
// Trix editor settings
if (typeof Trix === 'object') {
document.addEventListener('trix-initialize', (e) => {
document.querySelector('trix-toolbar .trix-button-group--history-tools').remove();
document.querySelector('trix-toolbar .trix-button-group--file-tools').remove();
document.querySelector('trix-toolbar .trix-button-group--history-tools')?.remove();
document.querySelector('trix-toolbar .trix-button-group--file-tools')?.remove();
});
document.addEventListener('trix-file-accept', (e) => {
e.preventDefault();
Expand Down
Loading