Add geometry type for curve#98
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a new Curve type (control points Vec) with constructors, accessors, From conversions, optional serde derives, and unit tests; wires the module into the crate and prelude; updates README and crate docs to document Curve and its serde support. ChangesCurve Geometric Primitive
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
utilForever
left a comment
There was a problem hiding this comment.
Can you check my comments? Thanks.
a4fbef1 to
6f2c7bb
Compare
|
Addressed both review comments by removing the redundant assertions from the curve tests. Checked locally with:
|
utilForever
left a comment
There was a problem hiding this comment.
LGTM now. Thanks for your work! 🦖
What
Add a
Curvegeometry type tobracket-geometry, storing 2D control points and exposing basic accessors for construction, endpoints, length, and emptiness.Why
Closes #93.
Validation
cargo check --allpassedcargo fmt --all -- --checkpassedcargo test -p bracket-geometrypassed: 99 unit tests and 7 doctestscargo clippy -p bracket-geometry --all-targets -- -D warnings -A clippy::multiple-crate-versionspassedcargo check -p bracket-geometry --features serdepassedgit diff --checkpassedNotes:
cargo test --allcould not complete locally because the machine ran out of disk while linking existingbracket-terminalexamples (ld: write() failed, errno=28).cargo clippy --workspace --all-targets -- -D warnings -A clippy::multiple-crate-versionscurrently stops on an existing lint inbracket-noise/src/fastnoise.rs:2777(clippy::collapsible_else_if), before reaching this change as a workspace-wide pass.Checklist
Required
cargo check --allpassescargo fmt --all -- --checkpassescargo clippy --workspace --all-targets -- -D warnings -A clippy::multiple-crate-versionspassescargo test --allpassesCloses #123)Functional Validation
Configuration & Docs
README.md,ARCHITECTURE.md, or relevant manual pages, if applicable)If Applicable
cargo auditlocally if needed)Summary by CodeRabbit
New Features
Documentation