Skip to content

Conversation

@george-angel
Copy link
Member

Pulling latest is dangerous as breaking changes can affect Production
deployments.

Removing imagePullPolicy: Always also means we remove immediate
dependency on Quay and can stop hammering them on every restart.

Pulling latest is dangerous as breaking changes can affect Production
deployments.

Removing `imagePullPolicy: Always` also means we remove immediate
dependency on Quay and can stop hammering them on every restart.
@george-angel george-angel requested a review from a team as a code owner October 21, 2025 05:03
@github-actions
Copy link
Contributor

Post kustomize build diff:

diff --git a/root-manifests/cockroachdb/manifests-cfssl/manifests.yaml b/built-manifests/cockroachdb/manifests-cfssl/manifests.yaml
index 5209cc6..cc0c2eb 100644
--- a/root-manifests/cockroachdb/manifests-cfssl/manifests.yaml
+++ b/built-manifests/cockroachdb/manifests-cfssl/manifests.yaml
@@ -180,7 +180,7 @@ spec:
             secretKeyRef:
               key: key
               name: ca.auth
-        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:latest
+        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:v1.0.0
         name: certs-refresh
         volumeMounts:
         - mountPath: /cockroach-certs
@@ -210,7 +210,7 @@ spec:
             secretKeyRef:
               key: key
               name: ca.auth
-        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:latest
+        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:v1.0.0
         name: init-certs
         volumeMounts:
         - mountPath: /cockroach-certs
@@ -348,8 +348,7 @@ spec:
             configMapKeyRef:
               key: cockroach.host
               name: cockroach
-        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:latest
-        imagePullPolicy: Always
+        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:v1.0.0
         livenessProbe:
           httpGet:
             path: /health
@@ -399,8 +398,7 @@ spec:
             configMapKeyRef:
               key: cockroach.host
               name: cockroach
-        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:latest
-        imagePullPolicy: Always
+        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:v1.0.0
         name: init-certs
         volumeMounts:
         - mountPath: /cockroach-certs
@@ -514,8 +512,7 @@ spec:
             secretKeyRef:
               key: key
               name: ca.auth
-        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:latest
-        imagePullPolicy: Always
+        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:v1.0.0
         name: init-certs
         volumeMounts:
         - mountPath: /cockroach-certs
@@ -584,8 +581,7 @@ spec:
             secretKeyRef:
               key: key
               name: ca.auth
-        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:latest
-        imagePullPolicy: Always
+        image: quay.io/utilitywarehouse/cockroach-cfssl-certs:v1.0.0
         name: init-certs
         volumeMounts:
         - mountPath: /cockroach-certs

=============================================
k8s objects: 0 to add, 0 to destroy
6 changed hunks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant