Skip to content

Fix bat launches, don't change booting splash logic - #1920

Merged
utkarshdalal merged 1 commit into
masterfrom
fix-bat-launch-not-showing
Sep 12, 2026
Merged

Fix bat launches, don't change booting splash logic#1920
utkarshdalal merged 1 commit into
masterfrom
fix-bat-launch-not-showing

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Description

Bat files were not loading like they used to - the booting splash stayed showing. This fixes it.

Recording

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Fixes launching .bat files so they load correctly and the booting splash no longer stays stuck. Adjusts how shell windows are ignored during boot to only ignore explorer.exe, and ensures .bat executables get the proper working directory and are not filtered out by absolute path checks.

Written for commit 4f526ee. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved startup behavior so the boot screen no longer waits unnecessarily when no boot advertisement is displayed.
    • Prevented the desktop shell from being mistaken for the launched game window.
    • Improved launching of batch-file-based games through the appropriate compatibility path.
    • Reduced incorrect executable path handling during game startup for more reliable launches.

@utkarshdalal
utkarshdalal merged commit b29f6f5 into master Sep 12, 2026
2 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1d7f5108-a5ed-4c36-8d9d-c141d313ba6f

📥 Commits

Reviewing files that changed from the base of the PR and between 5cdc906 and 4f526ee.

📒 Files selected for processing (2)
  • app/src/main/java/app/gamenative/ui/model/MainViewModel.kt
  • app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt

📝 Walkthrough

Walkthrough

The changes refine boot splash window detection, route .bat executables through legacy DRM handling, and exclude absolute Windows paths from Steamless processing.

Changes

Boot window handling

Layer / File(s) Summary
Boot splash and mapped-window filtering
app/src/main/java/app/gamenative/ui/model/MainViewModel.kt
launchApp waits for a game window only when a boot ad is present. onWindowMapped ignores empty and explorer.exe window classes while awaiting a game window.

Executable launch handling

Layer / File(s) Summary
Batch launch routing and path filtering
app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
.bat executables use the legacy DRM launch path. Steamless filters exclude absolute Windows paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: xxjsonderuloxx

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-bat-launch-not-showing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant