Add in-app updater structure with markdown rendering #7334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested it? |
|
yes, it compiles and renders the correct markdown. I'll send screenshots to show off the changes. the changes lay off a base for some future security checks, but i can remove it |
|
No I mean does the update actually work? |
|
I'll need more testing on that. i tested these scenarios in ios and macos:
for ios it stops there, just prompts the user to the apple store or the guide for sideloaded apps. for macos i need to test the installation process. I'll let you know as soon as i have the time! |
- opt for a simple DMG open instead of a more complicate in-place update
osy
force-pushed
the
main
branch
2 times, most recently
from
3c98442 to
a0978bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a framework for an in-app updater, including UI elements for checking updates and displaying update information. This enhances user experience. this is my first time dealing with swift (and iOS / macOS development).. so expect some issues :_) . i wanted to put a starting base since the feature is quite usefull and the issue is very old. thanks to those who will do the code review :)
Closes: #3378