Skip to content

Conversation

cantonios
Copy link

Description

The existing Eigen threadpool test uses an incorrect version comparison, which breaks with any new development branch or released version Eigen. Setting the dependency to anything newer than 3.3.7 that is not a 3.x development branch will trigger a build error. For example, with the recently released Eigen 5.0.0.

This change corrects the version comparison for the switch from Eigen::NonBlockingThreadPool to Eigen::ThreadPool, which happened with release 3.3.8.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • [N/A] Have you added relevant regression tests?

@cantonios cantonios requested a review from a team as a code owner October 10, 2025 21:18
@github-actions github-actions bot added the component:tests Codeowner: @oneapi-src/onednn-arch label Oct 10, 2025
@cantonios
Copy link
Author

@dzarukin fixing an Eigen issue encountered internally at Google

@cantonios cantonios changed the title Fix Eigen version comparison. eigen: Fix Eigen version comparison. Oct 10, 2025
The existing Eigen threadpool test uses an incorrect version comparison, which
breaks with any Eigen new development branch or released version.

This change corrects the version comparison for the switch from
`Eigen::NonBlockingThreadPool` to `Eigen::ThreadPool`, which happened
with release 3.3.8.
@dzarukin
Copy link
Contributor

Hi @cantonios, thanks for taking care about it. I have a PR opened where I completely got rid of it: #4087 and switch to ThreadPool object instead for synchronous implementation (coming from Tensor header). We plan to move to v5.0.0 and set it as a minimal version, hope it's aligned with your plans.

@cantonios
Copy link
Author

Hi @cantonios, thanks for taking care about it. I have a PR opened where I completely got rid of it: #4087 and switch to ThreadPool object instead for synchronous implementation (coming from Tensor header). We plan to move to v5.0.0 and set it as a minimal version, hope it's aligned with your plans.

Okay, great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:tests Codeowner: @oneapi-src/onednn-arch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants