eigen: Fix Eigen version comparison. #4112
Open
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing Eigen threadpool test uses an incorrect version comparison, which breaks with any new development branch or released version Eigen. Setting the dependency to anything newer than 3.3.7 that is not a 3.x development branch will trigger a build error. For example, with the recently released Eigen 5.0.0.
This change corrects the version comparison for the switch from
Eigen::NonBlockingThreadPool
toEigen::ThreadPool
, which happened with release 3.3.8.Checklist
General
make test
andmake test_benchdnn_*
) pass locally for each commit?Bug fixes