xe: jit: fix shr usage #4146
Open
xe: jit: fix shr usage #4146
+31
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make test |
atkassen
approved these changes
Oct 15, 2025
| mach(1, _qot, _x, m); | ||
| shr<uint32_t>(1, _qot, _qot, p - 32); | ||
| // qot = (x * m) >> p | ||
| bool use_mach = true; |
There was a problem hiding this comment.
nit: const to prevent a coverity complaint
There was a problem hiding this comment.
This variable is updated in embargo code so it has to be non-const. Can I add // NOLINT comment to ignore that?
There was a problem hiding this comment.
We can just dismiss the coverity hit later.
src/gpu/intel/jit/codegen/kernel.hpp
Outdated
| template <typename DT = void> | ||
| void eshr(const ngen::InstructionModifier &mod, ngen::RegData dst, | ||
| ngen::RegData src0, ngen::RegData src1) { | ||
| bool is_q = ngen_is_qw(src0.getType()); |
echeresh
force-pushed
the
echeresh/shr
branch
from
9946bac to
4eef761
Compare
kealan-barbieri
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR switches
shr(bitwise right shift) usage toeshr(emulated bitwise right shift) to ensure that signed types are properly dispatched toasr(arithmetic right shift).