[oneDPL][rfc][ranges] proposal for implementation of the second part of range based API for oneDPL #2037
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Support the second portion of the oneDPL Range APIs | ||
|
|
||
| ## Introduction | ||
| Based on statistics (observing C++ code within github.com) for the usage of popular algorithms, the following | ||
| range-based APIs are suggested to be implemented next in oneDPL. | ||
| `fill`, `generate`, `move`, `replace`, `replace_if`, `remove`, `remove_if`, `mismatch`, `minmax_element`, `minmax`, | ||
| `min`, `max`, `find_first_of`, `find_end`, `is_sorted_until` | ||
|
|
||
| ## Motivations | ||
| The feature is proposed as the next step of range-based API support for oneDPL. | ||
|
|
||
| ### Key Requirements | ||
| - The range-based signatures for the mentioned API should correspond to the proposal for C++ parallel range algorithms, P3179. | ||
| (https://wg21.link/p3179) | ||
| - The proposed implementation should support all oneDPL execution policies: `seq`, `unseq`, `par`, `par_unseq` and `a device policy`. | ||
MikeDvorskiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ### Implementation proposal | ||
| - The implementation is supposed to rely on existing range-based or iterator-based algorithm patterns, which are already | ||
| implemented in oneDPL. | ||
| - Several algorithms described in P3179 have slightly different semantics. To implement these, some existing algorithm patterns | ||
| might require modifications or new versions. | ||
|
|
||
| ### Test coverage | ||
|
|
||
| - It should be called with both small and large data sizes and with all the policies mentioned above. | ||
|
There was a problem hiding this comment. Does it make sense to also mention what kinds of input and output ranges (containers, views, etc.) will be tested? There was a problem hiding this comment. Yes, it does. |
||
| - Output data, return type, and value should be checked/compared with the reference result | ||
| computed by the corresponding serial std::ranges algorithm or by a custom implemented serial version | ||
| in case of different semantics. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an exception to this rule, we might have
mismatchto followequalandtransformin the oneDPL specification and allow only one of the two ranges to be sized.I am still thinking of the best way to handle this.