Avoid specializations of the same submitters with the some policy type but with different qualifiers #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
changed the title
SergeyKopienko
force-pushed
the
dev/skopienko/fix_exec_policy_type_in_submitters
branch
from
c3a8c90 to
8616736
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/fix_exec_policy_type_in_submitters
branch
2 times, most recently
from
c4df97f to
bf990be
Compare
…egment_submitter_factory for __sycl_scan_by_segment_submitter (__sycl_scan_by_segment_impl)
… _CustomName template param from __parallel_scan_submitter
….h - change static submit method to operator()(...) const in the __parallel_radix_sort_iteration
… change static submit method to operator()(...) const in the __parallel_transform_reduce_impl
…truct __sycl_submitter_base
…utionPolicy not required anymore inside __kernel_name_generator params in __sycl_scan_by_segment_submitter
…Policy type always first in factories and submitters template parameters
SergeyKopienko
force-pushed
the
dev/skopienko/fix_exec_policy_type_in_submitters
branch
from
9823a99 to
7029dcc
Compare
|
Closed because the approach from #2093 look more preferable |
SergeyKopienko
deleted the
dev/skopienko/fix_exec_policy_type_in_submitters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmichel11, @danhoeflinger In this draft PR I describes my ideas how to avoid that.
I am just started, so it's not final state now.
Also I want to fix in this PR the issue #2083