RFC: Custom backends and policies for Dynamic Selection #2220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egfefey
reviewed
May 2, 2025
egfefey
reviewed
May 2, 2025
egfefey
reviewed
May 2, 2025
egfefey
reviewed
May 2, 2025
egfefey
reviewed
May 2, 2025
| The `get_submission_group` is not easily implemented in a meaningful way. It must return a type that | ||
| defines a member function `wait`. But since there is no way to know how to wait on all previous submissions | ||
| for an arbitrary backend resource, this function will likely need to return a dummy type or | ||
| `get_submission_group` be undefined for the default backend. |
There was a problem hiding this comment.
If we could provide a way to have the user give us the wait type, do we have a shot? Or maybe it's better to leave this out to make the default case simple.
There was a problem hiding this comment.
Lets consider if there's a meaningful default or not. I'm not sure that there is.
There was a problem hiding this comment.
I think a meaningful default is to call wait on all resources, if they have a wait function.
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_policies.md
Outdated
Show resolved
Hide resolved
vossmjp
changed the title
vossmjp
changed the title
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
rfcs/proposed/dynamic_selection_customization/custom_backends.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very rough draft for custom backends for dynamic selection.