Add CA_LLVM_LIBDIR_SUFFIX. #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
reviewed
Mar 6, 2025
When building against an LLVM that was built with LLVM_LIBDIR_SUFFIX set, we would fail to locate that LLVM's CMake files due to hardcoded paths. Allow CA_LLVM_LIBDIR_SUFFIX to be set to the same value to work around that.
coldav
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add CA_LLVM_LIBDIR_SUFFIX.
Reason for change
When building against an LLVM that was built with LLVM_LIBDIR_SUFFIX set, we would fail to locate that LLVM's CMake files due to hardcoded paths.
Description of change
Allow CA_LLVM_LIBDIR_SUFFIX to be set to the same value to work around that.
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist