Skip to content

Conversation

Vika-F
Copy link
Contributor

@Vika-F Vika-F commented Oct 22, 2024

Description

Add a comprehensive description of proposed changes

List associated issue number(s) if exist(s): #6 (for example)

Documentation PR (if needed): #1340 (for example)

Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Vika-F Vika-F added the testing Tests for sklearnex/daal4py/onedal4py & patching sklearn label Oct 22, 2024
@Vika-F
Copy link
Contributor Author

Vika-F commented Oct 22, 2024

/intelci: run

@icfaust
Copy link
Contributor

icfaust commented Oct 16, 2025

@Vika-F I am starting to mess with these tests and shift them out of the onedal folder. Should we accelerate these changes here or fold them into my PR for array API in SVM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Tests for sklearnex/daal4py/onedal4py & patching sklearn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants