Skip to content

Conversation

napetrov
Copy link
Contributor

Description

@napetrov napetrov added the enhancement New feature or request label Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 80.65% <ø> (?)
github 73.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@david-cortes-intel david-cortes-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of what this PR introduces will get outdated as soon as any non-trivial change is made (e.g. additional examples, refactorings that move things across files, new software releases, rewrites of some doc page, among others).

- **Setup**: Requires MPI (Intel MPI or OpenMPI), mpi4py
- **Testing**: `mpirun -n 4` for validation

**MPI Requirements** (from setup.py):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look relevant.

- **oneDAL**: Downloads nightly builds from upstream oneDAL repo
- **Python**: Matrix testing across Python 3.9-3.13 (verified in .ci/pipeline/ci.yml)
- **sklearn**: Multiple version compatibility (1.0-1.7)
- **GPU Libraries**: dpctl, dpnp for Intel GPU acceleration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing torch.

## Build Dependencies
- **oneDAL**: Downloads nightly builds from upstream oneDAL repo
- **Python**: Matrix testing across Python 3.9-3.13 (verified in .ci/pipeline/ci.yml)
- **sklearn**: Multiple version compatibility (1.0-1.7)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bound to get outdated. Perhaps could rephrase it as "all sklearn versions beyond 1.0", or "last 3 releases of sklearn", or something like that.

## Quality Gates
- **Linting**: black, isort, clang-format, numpydoc validation
- **Testing**: pytest with cross-platform compatibility
- **Coverage**: codecov integration with threshold enforcement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have a threshold enforcement from codecov.


### Platform-Specific Build Commands

**Linux/macOS** (from .ci/pipeline/build-and-test-lnx.yml):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support macOS.


# Set up environment
source /opt/intel/oneapi/compiler/latest/env/vars.sh
export DPCPPROOT=/opt/intel/oneapi/compiler/latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

- **Statistics**: Basic statistics, covariance

## For AI Agents
- Use `config_context` for device selection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not meant to be used inside onedal/.

@@ -0,0 +1,80 @@
# AGENTS.md - Code Generator (generator/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this folder warrants a file for agents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants