Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

@david-cortes-intel david-cortes-intel commented Nov 19, 2025

Description

This PR makes some necessary adjustments for planned changes (from currently unmerged PRs) for the upcoming scikit-learn 1.8 release to the logistic regression class, including:

  • Deprecation of the penalty parameter.
  • Changing the default l1_ratio from 'None' to 0 (which sets the penalty automatically).
  • Deprecation of multiclass argument while still allowing it to be passed.

Along the way, it also updates the documentation on supported algorithms to reflect the new parameters, and corrects a code comment that is not entirely valid after earlier refactorings of logistic regression for the upcoming sklearn release.

Note: since the changes in sklearn that this is meant to adjust towards haven't been merged yet, it's not possible to test this PR in CIs.


Checklist:

Completeness and readability

  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • All CI jobs are green or I have provided justification why they aren't.

@david-cortes-intel david-cortes-intel added the sklearn-patch sklearn patching label Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 80.49% <ø> (ø)
github 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sklearnex/linear_model/logistic_regression.py 57.24% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@icfaust
Copy link
Contributor

icfaust commented Nov 19, 2025

Please reference the under development PRs for completeness and traceability (32659). The PRs can be verified by modifying here (https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/.ci/scripts/setup_sklearn.sh#L32) and running the nightly (/azp run Nightly) and then returning the state.

@david-cortes-intel david-cortes-intel changed the title MAINT: More adjustments for changes in sklearn1.8 LogisticRegression [Do NOT merge yet] MAINT: More adjustments for changes in sklearn1.8 LogisticRegression Nov 20, 2025
@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@david-cortes-intel
Copy link
Contributor Author

/azp run Nightly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sklearn-patch sklearn patching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants