[Do NOT merge yet] MAINT: More adjustments for changes in sklearn1.8 LogisticRegression #2784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some necessary adjustments for planned changes (from currently unmerged PRs) for the upcoming scikit-learn 1.8 release to the logistic regression class, including:
Along the way, it also updates the documentation on supported algorithms to reflect the new parameters, and corrects a code comment that is not entirely valid after earlier refactorings of logistic regression for the upcoming sklearn release.
Note: since the changes in sklearn that this is meant to adjust towards haven't been merged yet, it's not possible to test this PR in CIs.
Checklist:
Completeness and readability
Testing