Skip to content

Conversation

@va259
Copy link
Owner

@va259 va259 commented Jun 12, 2022

Please check back by Wed, Jun 15 – I'm having issues with AWS and I hope to solve them within 2 days. Thank you for understanding!

@barachenia
Copy link

sure, w8 for u :)

@va259
Copy link
Owner Author

va259 commented Jun 16, 2022

The BE and FE use one and same json file for mock data: https://github.com/va259/aws-cloud-development-be/blob/task-3-lambda/products-service/assets/fixtures.js

URLs to services:

GET - https://12s93b7kre.execute-api.us-east-1.amazonaws.com/products
GET - https://12s93b7kre.execute-api.us-east-1.amazonaws.com/products/{id} (can be tested with e.g. id: bfd22822-ec93-11ec-8ea0-0242ac120002 or any other id from the fixtures file above)

[+] 1 - Product-service serverless config contains configuration for 2 lambda functions, API is not working at all, but YAML configuration is correct
[+] 2 - The getProductsList OR getProductsById lambda function returns a correct response (POINT1)
[+] 3 - The getProductsById AND getProductsList lambda functions return a correct response code (POINT2)
[+] 4 - Your own Frontend application is integrated with product service (/products API) and products from product-service are represented on Frontend. AND POINT1 and POINT2 are done.

Additional scope

[?+] +1 - Async/await is used in lambda functions
[-] +1 - ES6 modules are used for product-service implementation (I was not able to use ES6 modules due to internal AWS Lambda error and had no time to work on TS version)
[-] +1 - Webpack is configured for product-service
[-] +1 (All languages) - SWAGGER documentation is created for product-service
[-] +1 (All languages) - Lambda handlers are covered by basic UNIT tests (NO infrastructure logic is needed to be covered)
[+] +1 (All languages) - Lambda handlers (getProductsList, getProductsById) code is written not in 1 single module (file) and separated in codebase.
[+] +1 (All languages) - Main error scenarious are handled by API ("Product not found" error).

@va259 va259 changed the title initi: package.json added init: getProductsList & getProductById services added Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants