Skip to content

fix: move tooltip slot to field container (#10410) (CP: 24.9) #10421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
+116 −114
Merged

fix: move tooltip slot to field container (#10410) (CP: 24.9) #10421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d019e3
fix: move tooltip slot to field container (#10410)
DiegoCardoso Nov 3, 2025
42a927e
fix: add number and integer fields
web-padawan Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/combo-box/src/vaadin-combo-box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ class ComboBox extends ComboBoxDataProviderMixin(
<div part="error-message">
<slot name="error-message"></slot>
</div>

<slot name="tooltip"></slot>
</div>

<vaadin-combo-box-overlay
Expand All @@ -220,8 +222,6 @@ class ComboBox extends ComboBoxDataProviderMixin(
position-target="[[_positionTarget]]"
no-vertical-overlap
></vaadin-combo-box-overlay>

<slot name="tooltip"></slot>
`;
}

Expand Down
20 changes: 10 additions & 10 deletions packages/combo-box/test/dom/__snapshots__/combo-box.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,8 @@ snapshots["vaadin-combo-box shadow default"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-combo-box-overlay
id="overlay"
Expand All @@ -538,8 +540,6 @@ snapshots["vaadin-combo-box shadow default"] =
>
</vaadin-combo-box-scroller>
</vaadin-combo-box-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-combo-box shadow default */

Expand Down Expand Up @@ -588,6 +588,8 @@ snapshots["vaadin-combo-box shadow disabled"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-combo-box-overlay
id="overlay"
Expand All @@ -599,8 +601,6 @@ snapshots["vaadin-combo-box shadow disabled"] =
>
</vaadin-combo-box-scroller>
</vaadin-combo-box-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-combo-box shadow disabled */

Expand Down Expand Up @@ -649,6 +649,8 @@ snapshots["vaadin-combo-box shadow readonly"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-combo-box-overlay
id="overlay"
Expand All @@ -660,8 +662,6 @@ snapshots["vaadin-combo-box shadow readonly"] =
>
</vaadin-combo-box-scroller>
</vaadin-combo-box-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-combo-box shadow readonly */

Expand Down Expand Up @@ -710,6 +710,8 @@ snapshots["vaadin-combo-box shadow invalid"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-combo-box-overlay
id="overlay"
Expand All @@ -721,8 +723,6 @@ snapshots["vaadin-combo-box shadow invalid"] =
>
</vaadin-combo-box-scroller>
</vaadin-combo-box-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-combo-box shadow invalid */

Expand Down Expand Up @@ -771,6 +771,8 @@ snapshots["vaadin-combo-box shadow theme"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-combo-box-overlay
id="overlay"
Expand All @@ -783,8 +785,6 @@ snapshots["vaadin-combo-box shadow theme"] =
>
</vaadin-combo-box-scroller>
</vaadin-combo-box-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-combo-box shadow theme */

4 changes: 2 additions & 2 deletions packages/date-picker/src/vaadin-date-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ class DatePicker extends DatePickerMixin(InputControlMixin(ThemableMixin(Element
<div part="error-message">
<slot name="error-message"></slot>
</div>

<slot name="tooltip"></slot>
</div>

<vaadin-date-picker-overlay
Expand All @@ -205,8 +207,6 @@ class DatePicker extends DatePickerMixin(InputControlMixin(ThemableMixin(Element
restore-focus-on-close
restore-focus-node="[[inputElement]]"
></vaadin-date-picker-overlay>

<slot name="tooltip"></slot>
`;
}

Expand Down
20 changes: 10 additions & 10 deletions packages/date-picker/test/dom/__snapshots__/date-picker.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,14 +830,14 @@ snapshots["vaadin-date-picker shadow default"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-date-picker-overlay
id="overlay"
restore-focus-on-close=""
>
</vaadin-date-picker-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-date-picker shadow default */

Expand Down Expand Up @@ -885,14 +885,14 @@ snapshots["vaadin-date-picker shadow disabled"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-date-picker-overlay
id="overlay"
restore-focus-on-close=""
>
</vaadin-date-picker-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-date-picker shadow disabled */

Expand Down Expand Up @@ -940,14 +940,14 @@ snapshots["vaadin-date-picker shadow readonly"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-date-picker-overlay
id="overlay"
restore-focus-on-close=""
>
</vaadin-date-picker-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-date-picker shadow readonly */

Expand Down Expand Up @@ -995,14 +995,14 @@ snapshots["vaadin-date-picker shadow invalid"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-date-picker-overlay
id="overlay"
restore-focus-on-close=""
>
</vaadin-date-picker-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-date-picker shadow invalid */

Expand Down Expand Up @@ -1050,15 +1050,15 @@ snapshots["vaadin-date-picker shadow theme"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<vaadin-date-picker-overlay
id="overlay"
restore-focus-on-close=""
theme="align-right"
>
</vaadin-date-picker-overlay>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-date-picker shadow theme */

20 changes: 10 additions & 10 deletions packages/email-field/test/dom/__snapshots__/email-field.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@ snapshots["vaadin-email-field shadow default"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-email-field shadow default */

Expand Down Expand Up @@ -174,9 +174,9 @@ snapshots["vaadin-email-field shadow disabled"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-email-field shadow disabled */

Expand Down Expand Up @@ -223,9 +223,9 @@ snapshots["vaadin-email-field shadow readonly"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-email-field shadow readonly */

Expand Down Expand Up @@ -272,9 +272,9 @@ snapshots["vaadin-email-field shadow invalid"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-email-field shadow invalid */

Expand Down Expand Up @@ -321,9 +321,9 @@ snapshots["vaadin-email-field shadow theme"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-email-field shadow theme */

24 changes: 12 additions & 12 deletions packages/integer-field/test/dom/__snapshots__/integer-field.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ snapshots["vaadin-integer-field shadow default"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-integer-field shadow default */

Expand Down Expand Up @@ -204,9 +204,9 @@ snapshots["vaadin-integer-field shadow step-buttons-visible"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-integer-field shadow step-buttons-visible */

Expand Down Expand Up @@ -267,9 +267,9 @@ snapshots["vaadin-integer-field shadow disabled"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-integer-field shadow disabled */

Expand Down Expand Up @@ -330,9 +330,9 @@ snapshots["vaadin-integer-field shadow readonly"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-integer-field shadow readonly */

Expand Down Expand Up @@ -393,9 +393,9 @@ snapshots["vaadin-integer-field shadow invalid"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-integer-field shadow invalid */

Expand Down Expand Up @@ -456,9 +456,9 @@ snapshots["vaadin-integer-field shadow theme"] =
<slot name="error-message">
</slot>
</div>
<slot name="tooltip">
</slot>
</div>
<slot name="tooltip">
</slot>
`;
/* end snapshot vaadin-integer-field shadow theme */

4 changes: 2 additions & 2 deletions packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,9 @@ class MultiSelectComboBox extends MultiSelectComboBoxMixin(ThemableMixin(Element
<div part="error-message">
<slot name="error-message"></slot>
</div>
</div>

<slot name="tooltip"></slot>
<slot name="tooltip"></slot>
</div>
`;
}
}
Expand Down
Loading