fix: offset all Argo CD sync-wave values by +31 to ensure positive waves#109
Open
minmzzhang wants to merge 3 commits intovalidatedpatterns:mainfrom
Open
fix: offset all Argo CD sync-wave values by +31 to ensure positive waves#109minmzzhang wants to merge 3 commits intovalidatedpatterns:mainfrom
minmzzhang wants to merge 3 commits intovalidatedpatterns:mainfrom
Conversation
minmzzhang
force-pushed
the
update-sync-wave
branch
from
1fbeedf to
fb07057
Compare
Collaborator
|
Overall it looks good to me. Let me test it. |
Collaborator
|
I tested this approach in a brand new cluster and it worked well. No errors and applications are synced without issues. |
The Validated Patterns operator now applies the Argo CD super-role (ClusterRole) later in the deployment lifecycle. Resources annotated with negative sync-wave values could attempt to sync before the role existed, causing failures. This adds +31 to every argocd.argoproj.io/sync-wave annotation across all charts, values-hub.yaml, and docs. Relative ordering is preserved; the smallest wave is now 1 (was -30). Inline comments referencing old wave numbers are updated to match. See docs/SYNC-WAVE-INVENTORY.md for a full old/current mapping table. Signed-off-by: Min Zhang <minzhang@redhat.com>
- Add explicit sync-wave to all active applications in values-hub.yaml - Add sync-wave 48 to commented supply-chain application - Wait for MachineConfigPool rollout before vault-config-jwt - Update SYNC-WAVE-INVENTORY with unified deployment timeline Signed-off-by: Min Zhang <minzhang@redhat.com>
…stergroup chart Apply the same +31 sync-wave offset convention to values-coco-dev.yaml so all waves are positive, matching values-hub.yaml. Revert the temporary clusterGroupChartVersion pin (0.9.45 -> 0.9.*) since positive-only waves eliminate the issue that prompted it. Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
force-pushed
the
update-sync-wave
branch
from
fb07057 to
5109e3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Validated Patterns operator now applies the Argo CD super-role (ClusterRole) later in the deployment lifecycle. Resources annotated with negative sync-wave values could attempt to sync before the role existed, causing failures.
This adds +31 to every argocd.argoproj.io/sync-wave annotation across all charts, values-hub.yaml, and docs. Relative ordering is preserved; the smallest wave is now 1 (was -30). Inline comments referencing old wave numbers are updated to match.
See docs/SYNC-WAVE-INVENTORY.md for a full old/current mapping table.