-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(ci): update build tooling #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2629 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2566 2566
Branches 651 651
=========================================
Hits 2566 2566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Because I want to validate that the regression of #2630 does not happen here, I will put this in draft |
|
I specified the target for compilation in |
rubiin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then
Updates the rollup version we use and introduces a separate build step in the CI so we test on the files that will also be published to npm. This also allows us to more easily update eslint in a future PR. It's a
featbecause there might be (very) minor changes to the build itself.This incorporates part of the changes of #2401
Checklist