Add *Buffer methods typings for XCLAIM/XAUTOCLAIM/XREADGROUP/XPENDING #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
force-pushed
the
sf-streams-types
branch
2 times, most recently
from
67a8cb3 to
b82b0bb
Compare
SiarheiFedartsou
force-pushed
the
sf-streams-types
branch
from
b82b0bb to
e2a6bbb
Compare
Signed-off-by: Siarhei Fedartsou <[email protected]>
SiarheiFedartsou
force-pushed
the
sf-streams-types
branch
from
e2a6bbb to
b8eeff7
Compare
SiarheiFedartsou
commented
Nov 2, 2024
| callback?: Callback<unknown[]> | ||
| ): Result<unknown[], Context>; | ||
|
|
||
| xautoclaimBuffer( |
There was a problem hiding this comment.
It is simple copy-paste for non-buffer version typings - I assume it is okay, but let me know if it isn't...
mcollina
requested changes
Nov 5, 2024
|
I think this is now done as the interface has been regenerated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating PR in original ioredis I realised that it is a bit "abondaned", so decided to create it in this fork.