Handle monitor stop gracefully when metrics server is dead - #431
Open
ravjotbrar wants to merge 1 commit into
Open
Handle monitor stop gracefully when metrics server is dead#431ravjotbrar wants to merge 1 commit into
ravjotbrar wants to merge 1 commit into
Conversation
Signed-off-by: ravjotb <ravjot.brar@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a metrics server crashes (process exits), clicking "Stop" in the UI fails silently — ECONNREFUSED on the stop request leaves monitorRunning: true in the frontend, causing a stuck banner.
In runMonitorForNode, when a stop request fails (catch block), send monitorFulfilled with monitorRunning: false instead of monitorError. The metrics server is dead, so monitor is effectively stopped. Start request errors still report as monitorError.
Before the change
Untitled.mov
After the change
Screen.Recording.2026-07-29.at.4.40.18.PM.mov