-
Notifications
You must be signed in to change notification settings - Fork 38
add snakeoil certificates #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
parimoh
wants to merge
9
commits into
valkey-io:mainline
Choose a base branch
from
parimoh:add-snakeoil-certs
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pari Mohite <[email protected]>
Signed-off-by: Pari Mohite <[email protected]>
roshkhatri
reviewed
Aug 8, 2025
Dockerfile.template
Outdated
Comment on lines
165
to
166
| printf '#!/bin/sh\nset -e\nif [ $# -ne 2 ]; then\n echo "Usage: make-ssl-cert <cert_file> <key_file>" >&2\n exit 1\nfi\nmkdir -p "$(dirname "$1")" "$(dirname "$2")"\nopenssl req -new -x509 -days 3650 -nodes -out "$1" -keyout "$2" -subj "/CN=localhost"\n' > /usr/local/bin/make-ssl-cert; \ | ||
| chmod +x /usr/local/bin/make-ssl-cert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this script like entrypoint.sh and copy it to the image??
We are essentially creating it on runtime here
|
Also can we add tests for these? |
Signed-off-by: Pari Mohite <[email protected]>
Signed-off-by: Pari Mohite <[email protected]>
Signed-off-by: Pari Mohite <[email protected]>
Signed-off-by: Pari Mohite <[email protected]>
Signed-off-by: Pari Mohite <[email protected]>
Signed-off-by: Pari Mohite <[email protected]>
Signed-off-by: Pari Mohite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address #54. I'm gonna test this / research a bit more on this as well just to make sure that it actually works as intended and does everything it's supposed to.
Summary
Adds make-ssl-cert functionality to both Debian and Alpine variants for generating self-signed certificates which allows for SSL/TLS testing capabilities.
Changes Made
Debian Images:
Alpine Images:
Usage Examples
Debian:
docker run --rm valkey:debian make-ssl-cert generate-default-snakeoilAlpine:
docker run --rm valkey:alpine make-ssl-cert /tmp/cert.pem /tmp/key.pemTesting
Size Impact